Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass DBG=1 to make to build for debug #607

Merged
merged 1 commit into from
Aug 15, 2022
Merged

Pass DBG=1 to make to build for debug #607

merged 1 commit into from
Aug 15, 2022

Conversation

thockin
Copy link
Member

@thockin thockin commented Aug 13, 2022 •
edited
Loading 

$ rm -f bin/linux_amd64/git-sync; make; file bin/linux_amd64/git-sync; ls -l bin/linux_amd64/git-sync
making bin/linux_amd64/git-sync
bin/linux_amd64/git-sync: ELF 64-bit LSB executable, x86-64, version 1 (SYSV), statically linked, Go BuildID=8ggzPLzGh-EzWa2Dh7b7/1TXCJ0weTEiz5c5UKYGG/v8JGce_5rjo0TttLtDiE/ahM4IwfEUSCR_9OMT5BH, stripped
-rwxr-xr-x 1 thockin primarygroup 9248768 Aug 13 16:47 bin/linux_amd64/git-sync

$ rm -f bin/linux_amd64/git-sync; make DBG=1; file bin/linux_amd64/git-sync; ls -l bin/linux_amd64/git-sync
making bin/linux_amd64/git-sync
bin/linux_amd64/git-sync: ELF 64-bit LSB executable, x86-64, version 1 (SYSV), statically linked, Go BuildID=a0s8zSFGr_qgRGx9bzAH/HPs8kT1ilha0T44qd_BK/v59mQiZ6XVAgCk3j9pBa/Z4RiOnHeMKvhiDWI8S3W, not stripped
-rwxr-xr-x 1 thockin primarygroup 14362860 Aug 13 16:47 bin/linux_amd64/git-sync

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 13, 2022
@k8s-ci-robot k8s-ci-robot requested review from nan-yu and stp-ip August 13, 2022 23:44
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 13, 2022
@thockin thockin added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 14, 2022
@thockin
Copy link
Member Author

thockin commented Aug 14, 2022

Hold - something is not right yet

@thockin thockin removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 14, 2022
@thockin
Copy link
Member Author

thockin commented Aug 14, 2022

Seems OK now

stp-ip
stp-ip approved these changes Aug 15, 2022
View reviewed changes
Copy link
Member

@stp-ip stp-ip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 15, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: stp-ip, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit b7082f6 into kubernetes:master Aug 15, 2022
@thockin thockin deleted the make_debug_bin branch February 25, 2023 22:43
@p-linnane p-linnane mentioned this pull request Aug 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stp-ip stp-ip stp-ip approved these changes

@nan-yu nan-yu Awaiting requested review from nan-yu

Assignees

@stp-ip stp-ip

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thockin @k8s-ci-robot @stp-ip